[CI] Make sure composer cache is properly used #15359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you Tobias. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #15358 made sure we had a composer cache folder. This PR is making sure we use the cache properly.
Currently, we are using the following paths:
/var/workspace//var/_checker//var/_sf_app/The issue is that
hashFilesonly works for files in/var/workspace/. So I moved everything down one level./var/workspace/docs/var/workspace/_checker//var/workspace/_sf_app/Now we will use the two new composer.lock files to know if we should save the github cache or not (ie if new dependencies were updated).
I think that the composer cache will contain many versions of a package. Ie, we dont need a separate cache for 4.4 and one of 5.2 etc.