Skip to content

[Security] Update ldap.rst #15567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2021
Merged

[Security] Update ldap.rst #15567

merged 1 commit into from
Aug 10, 2021

Conversation

mickadoo
Copy link
Contributor

Overview

Without the tags I was getting this error:

Cannot check credentials using the "Symfony\Component\Ldap\Ldap" ldap service, as such service is not found. Did you maybe forget to add the "ldap" service tag to this service?

Without the tags I was getting an error about the ldap service not being found and "Did you maybe forget to add the "ldap" service tag to this service?"
@javiereguiluz
Copy link
Member

@wouterj could you please confirm if this is correct? I see in Symfony a class called RegisterLdapLocatorPass created by you and which contains this code:

foreach ($container->findTaggedServiceIds('ldap') as $serviceId => $tags) {
    $locators[$serviceId] = new ServiceClosureArgument(new Reference($serviceId));
}

So this proposal looks correct, but I'd prefer to be sure. Thanks!

@carsonbot carsonbot changed the title Update ldap.rst [Security] Update ldap.rst Jul 29, 2021
@OskarStark OskarStark requested a review from wouterj August 4, 2021 14:30
@javiereguiluz javiereguiluz added this to the 5.3 milestone Aug 10, 2021
@javiereguiluz javiereguiluz merged commit 5f82197 into symfony:5.3 Aug 10, 2021
@mickadoo mickadoo deleted the patch-2 branch December 31, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants