Skip to content

added a note about database default charsets/collations #1563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 29, 2012
Merged

added a note about database default charsets/collations #1563

merged 5 commits into from
Jul 29, 2012

Conversation

inoryy
Copy link
Contributor

@inoryy inoryy commented Jul 15, 2012

One of the biggest "gotcha" moments symfony developers experience every now and then :D

:: code-block: bash

app/console doctrine:database:drop --force
app/console doctrine:database:create
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should place a $ in front of every bash line

They might even remember to do it the very first time, but forget that
it's all gone after running a relatively common command during development:

:: code-block: bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The format on these 2 code blocks isn't quite right - it should look like this:

.. code-block:: bash

@weaverryan
Copy link
Member

This is a real nice note Roman, but I think it's better-placed prominently in the Doctrine chapter. Can you find a good spot in that chapter and move it there?

Thanks!

@inoryy
Copy link
Contributor Author

inoryy commented Jul 26, 2012

@weaverryan I'm really not sure I like putting this note into doctrine chapter.

It is mainly aimed at newcomers, who usually only read just a few documentation pages to get stuff up and running.

@weaverryan
Copy link
Member

@Inori You have a fair point, but Symfony itself completely database-agnostic and other ORMs (Propel?) might actually handle this. So I think the only place for it is the Doctrine chapter, which hopefully a newcomer at least starts reading if they're using Doctrine.

@inoryy
Copy link
Contributor Author

inoryy commented Jul 27, 2012

@weaverryan ok, agreed :) Done!

$ app/console doctrine:database:create

There's no way to configure these defaults inside doctrine, as it tries to be
as agnostic as possible in terms of enviroment configuration, so only way around it
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the only way?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bschussek ha-ha, good catch! :D Fixed wording a bit

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I was just referring to the missing "the" :) But hey, even better now!

weaverryan added a commit that referenced this pull request Jul 29, 2012
added a note about database default charsets/collations
@weaverryan weaverryan merged commit e9e4324 into symfony:2.0 Jul 29, 2012
weaverryan added a commit that referenced this pull request Jul 29, 2012
@weaverryan
Copy link
Member

Thanks Roman - really excellent note!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants