Skip to content

[Routing] Use fourth argument of RoutingConfigurator instead of non-existent method #15773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Routing] Use fourth argument of RoutingConfigurator instead of non-existent method #15773

wants to merge 1 commit into from

Conversation

Jeroeny
Copy link
Contributor

@Jeroeny Jeroeny commented Sep 2, 2021 •
edited
Loading

$routeConfigurator->import returns ImportConfigurator, which doesn't seem to have the exclude method. Or am I missing something?

@carsonbot carsonbot added this to the 4.4 milestone Sep 2, 2021
@carsonbot carsonbot changed the title Use fourth argument of RoutingConfigurator instead of non-existent method [Routing] Use fourth argument of RoutingConfigurator instead of non-existent method Sep 3, 2021
HeahDude
HeahDude reviewed Sep 25, 2022
View reviewed changes
Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good catch, thanks!

javiereguiluz added a commit that referenced this pull request Oct 7, 2022
@javiereguiluz
minor #15773 [Routing] Use fourth argument of RoutingConfigurator ins…
16c1939 
…tead of non-existent method (Jeroeny)

This PR was merged into the 4.4 branch.

Discussion
----------

[Routing] Use fourth argument of RoutingConfigurator instead of non-existent method

`$routeConfigurator->import` returns [ImportConfigurator](https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Routing/Loader/Configurator/ImportConfigurator.php), which doesn't seem to have the `exclude` method. Or am I missing something?

Commits
-------

f86496c Use fourth argument of RoutingConfigurator instead of non-existent method
@javiereguiluz
Copy link
Member

Thank you Jeroen and sorry it took us so long to merge this.

@xabbuh
Copy link
Member

xabbuh commented Oct 9, 2022 •
edited
Loading

this was merged in f86496c and tweaked a bit afterwards in 83d0d4d

@xabbuh xabbuh closed this Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz left review comments

@HeahDude HeahDude HeahDude left review comments

Assignees
No one assigned
Labels
Routing Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@Jeroeny @javiereguiluz @xabbuh @HeahDude @carsonbot