Skip to content

Update cookbook/logging/monolog.rst #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2012
Merged

Conversation

tolry
Copy link
Contributor

@tolry tolry commented Jul 24, 2012

The use statement needs to be changed with current master. Also a hint to which config file needs to be edited would be nice.

@@ -205,6 +205,8 @@ using a processor.
}
}

Add this to ``app/config/config.yml``:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should put this on the first line of the code:

.. configuration-block::

    .. code-block:: yaml

        // app/config/config.yml
        yml code

    .. code-block:: xml

        // app/config/config.xml
        xml code

    .. code-block:: php

        // app/config/config.php
        php code

show destination config file in source-code rather than in the text (makes it easier, when offering xml & php configuration code as well)
@tolry
Copy link
Contributor Author

tolry commented Jul 25, 2012

Is this all right like this or should I add empty tabs for xml and php?

weaverryan added a commit that referenced this pull request Jul 29, 2012
Update cookbook/logging/monolog.rst
@weaverryan weaverryan merged commit d76091c into symfony:master Jul 29, 2012
weaverryan added a commit that referenced this pull request Jul 29, 2012
@weaverryan
Copy link
Member

Hi Tobias!

Great fix! I've merged this in and also added just a couple of descriptors about the file locations. These file locations are a bit tricky, as we'd normally say app/config/config.yml, but really, it's more common to have logging configuration in app/config/config_dev.yml or app/config/config_prod.yml, and services are more commonly configured in a bundle configuration file. But, I think this is a bit better, and hopefully good enough.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants