Skip to content

[Lock] Remove mention off DBAL Connection support for locking #15970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2023
Merged

[Lock] Remove mention off DBAL Connection support for locking #15970

merged 1 commit into from
Dec 19, 2023

Conversation

JohJohan
Copy link
Contributor

@JohJohan JohJohan commented Oct 20, 2021 •
edited
Loading

Fixes #15952 & #15950

@carsonbot carsonbot added this to the 6.0 milestone Oct 20, 2021
This was referenced Oct 20, 2021
Closed
Closed
@GromNaN
Copy link
Member

GromNaN commented Oct 20, 2021 •
edited
Loading

Since these features are deprecated in 5.4 and replaced by DoctrineDbalStore and DoctrineDbalPostgreSqlStore, this PR may target branch 5.4.

Also, the new classes needs to be documented. (related to #15903)

@JohJohan
Copy link
Contributor Author

@GromNaN if you think its a good idea to write all documentation in one pull request? There are multiple open issue to write documentation for this see: #15952 & #15950 & #15945

@GromNaN GromNaN mentioned this pull request Dec 10, 2021
Merged
javiereguiluz added a commit that referenced this pull request Dec 23, 2021
@javiereguiluz
minor #16217 [Lock] Add new Doctrine DBAL stores (GromNaN)
af8c0bf 
This PR was merged into the 5.4 branch.

Discussion
----------

[Lock] Add new Doctrine DBAL stores

Fix #16215 #15952 #15950 #15945 #15970

Commits
-------

62ba2e4 [Lock] Add new Doctrine DBAL stores
@OskarStark OskarStark modified the milestones: 6.0, 6.3 Aug 14, 2023
@OskarStark
Copy link
Contributor

Can you please rebase on top of 6.3 branch? Thanks

@JohJohan JohJohan changed the base branch from 6.0 to 6.3 August 14, 2023 08:58
@JohJohan
Copy link
Contributor Author

@OskarStark done :)

@OskarStark OskarStark changed the title [Lock] 15952 Remove mention off DBAL Connection support for locking [Lock] Remove mention off DBAL Connection support for locking Aug 14, 2023
@alexandre-daubois
Copy link
Member

Any news on this PR? This would close 6.0 milestone and two more issues 💪

@OskarStark
Copy link
Contributor

Thank you Johan.

@OskarStark OskarStark merged commit 443d6c6 into symfony:6.3 Dec 19, 2023
@JohJohan JohJohan deleted the 15952 branch December 19, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh

@OskarStark OskarStark Awaiting requested review from OskarStark

Assignees
No one assigned
Labels
Lock Status: Needs Review
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
5 participants
@JohJohan @GromNaN @OskarStark @alexandre-daubois @carsonbot