[Validator] [Validation] Add idiomatic way to check if there constraint violations #15983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ConstraintViolationList class cannot be used with PHP's built-in function empty(...) because it is an object, so we have to use the non-idiomatic count($violationList) === 0 or $violationList->count() === 0. It would be better to have a more idiomatic way to determine if any violations exist via an isEmpty() method. Relevant PR symfony/symfony#43643
carsonbot
changed the title
|
Closing in favor of #16029, thanks for the PR. |
javiereguiluz
added a commit
that referenced
this pull request
Oct 28, 2021
…s (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [Validator] [Validation] improve code for counting errors Replaces #15983 Follows the discussion at symfony/symfony#43643 Commits ------- 3cae3a1 [Validation] improve code for counting errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ConstraintViolationList class cannot be used with PHP's built-in function empty(...) because it is an object, so we have to use the non-idiomatic count($violationList) === 0 or $violationList->count() === 0.
It would be better to have a more idiomatic way to determine if any violations exist via an isEmpty() method.
Relevant PR symfony/symfony#43643