Skip to content

[Security] Fix method for the user password hasher service #16085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

samnela
Copy link
Contributor

@samnela samnela commented Nov 8, 2021

No description provided.

@javiereguiluz
Copy link
Member

@chalasr just asking, why does the UserPasswordHasher define methods like hashPassword() instead of implementing the PasswordHasherInterface, which uses methods like hash()? Thanks!

@chalasr
Copy link
Member

chalasr commented Nov 9, 2021

@javiereguiluz It cannot implement nor extend the PasswordHasherInterface as there would be a signature mismatch (the $user parameter only exists in UserPasswordHasherInterface).
I guess you are mostly wondering about why they have a different name, and I have to admit that I don't know.
Maybe it was in the hope of making it clear that it's about hashing the password for the passed user, but I'm not sure it does.

@javiereguiluz
Copy link
Member

Thanks Samuel ... and thanks Robin for the review!

@samnela samnela deleted the patch-1 branch November 17, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants