-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Adding folder name #16128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding folder name #16128
Conversation
frontend/encore/versioning.rst
Outdated
Whenever you run Encore, two configuration files are generated in your | ||
``public/build/`` folder: ``entrypoints.json`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a possibility of changing public/build/
path in webpack.config.js
file, so I think it is better to use the following text:
Whenever you run Encore, two configuration files are generated in directory where compiled assets will be stored: ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The point of this change it to make it easier for people who do not know where stuff gets generated. Those who have changed the setting themselves, will know to what they changed it ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is better for the text to be clear and transparent for everyone. Therefore, this text can be placed in such a way that even beginners can use it more easily
Whenever you run Encore, two configuration files are generated in directory where compiled assets will be stored (By default ``public/build/`` folder) : ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. I shortened it a bit. "Output folder" is taken from .setOutputPath()
(in webpack.config.js
)
a8ee1fc
to
bcf1675
Compare
Thanks |
No description provided.