Skip to content

Adding folder name #16128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Adding folder name #16128

merged 1 commit into from
Nov 23, 2021

Conversation

ThomasLandauer
Copy link
Contributor

No description provided.

Comment on lines 31 to 32
Whenever you run Encore, two configuration files are generated in your
``public/build/`` folder: ``entrypoints.json``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a possibility of changing public/build/ path in webpack.config.js file, so I think it is better to use the following text:

Whenever you run Encore, two configuration files are generated in directory where compiled assets will be stored: ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point of this change it to make it easier for people who do not know where stuff gets generated. Those who have changed the setting themselves, will know to what they changed it ;-)

Copy link
Contributor

@BahmanMD BahmanMD Nov 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better for the text to be clear and transparent for everyone. Therefore, this text can be placed in such a way that even beginners can use it more easily

Whenever you run Encore, two configuration files are generated in directory where compiled assets will be stored (By default ``public/build/`` folder) : ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I shortened it a bit. "Output folder" is taken from .setOutputPath() (in webpack.config.js)

@javiereguiluz
Copy link
Member

Thanks

@javiereguiluz javiereguiluz merged commit 08548d1 into symfony:4.4 Nov 23, 2021
@ThomasLandauer ThomasLandauer deleted the patch-12 branch November 23, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants