[Config] Fix missing argument #1623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If YamlUserLoader corresponds to the definition above (which extends FileLocator), then it should receive a FileLocatorInterface for the first argument of its constructor.
weaverryan
added a commit
that referenced
this pull request
Aug 12, 2012
[Config] Fix missing argument
|
Hey Matthieu! Real good catch and PR - fix makes perfect sense - I've merged this in. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
YamlUserLoadercorresponds to the definition above (which extendsFileLocator), then it should receive aFileLocatorInterfacefor the first argument of its constructor.The
$locatorvariable here is the one defined above in the page.