Skip to content

Correct spelling & grammar in 4.4 logging/ #16276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion logging/handlers.rst
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ ElasticsearchLogstashHandler
The ``ElasticsearchLogstashHandler`` was introduced in Symfony 4.4.

This handler deals directly with the HTTP interface of Elasticsearch. This means
it will slow down your application if Elasticsearch takes times to answer. Even
it will slow down your application if Elasticsearch takes time to answer. Even
if all HTTP calls are done asynchronously.

In a development environment, it's fine to keep the default configuration: for
Expand Down
2 changes: 1 addition & 1 deletion logging/monolog_console.rst
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ The example above could then be rewritten as::

Depending on the verbosity level that the command is run in and the user's
configuration (see below), these messages may or may not be displayed to
the console. If they are displayed, they are timestamped and colored appropriately.
the console. If they are displayed, they are time-stamped and colored appropriately.
Additionally, error logs are written to the error output (``php://stderr``).
There is no need to conditionally handle the verbosity settings anymore.

Expand Down
4 changes: 2 additions & 2 deletions logging/monolog_email.rst
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,8 @@ is then passed onto the ``deduplicated`` handler.

The ``deduplicated`` handler keeps all the messages for a request and then
passes them onto the nested handler in one go, but only if the records are
unique over a given period of time (60 seconds by default). If the records are
duplicated they are discarded. Adding this handler reduces the amount of
unique over a given period of time (60 seconds by default). Duplicated records are
discarded. Adding this handler reduces the amount of
notifications to a manageable level, specially in critical failure scenarios.
You can adjust the time period using the ``time`` option:

Expand Down
2 changes: 1 addition & 1 deletion logging/processors.rst
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ Symfony's MonologBridge provides processors that can be registered inside your a
Adds information about current route (controller, action, route parameters).

:class:`Symfony\\Bridge\\Monolog\\Processor\\ConsoleCommandProcessor`
Adds information about current console command.
Adds information about the current console command.

.. versionadded:: 4.3

Expand Down