Added change that brought me in doubt while doing this in my code #1632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Artem! Yes, you're right! I've also clarified this in a few more spots, since as you already know, it's quite important (and wasn't explained enough yet imo). Since this also applies to the 2.0 branch, I patched your commit at sha: 2bd434e Thanks! |
weaverryan
added a commit
that referenced
this pull request
Aug 25, 2012
|
No problem. Just trying to make Symfony2 as good as it can be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was wondering why my cache will not work if just setting last-modified header. Found that Symfony set private must-revalidate header by default. Hope this will help other people to understand this better.