Skip to content

Improvements around documentation images #16346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2021

Conversation

94noni
Copy link
Contributor

@94noni 94noni commented Dec 29, 2021

I target v5.4 as it is the latest lts
(even if some screenshots are v6)

@carsonbot carsonbot added this to the 5.4 milestone Dec 29, 2021
@javiereguiluz
Copy link
Member

Antoine, thanks a lot for taking care of updating these screenshots.

Sadly, they are too big in byte size. Previous images were much smaller in bytes. Please, try to use this free app -> https://squoosh.app/ to reduce their size. If they don't reduce their size much, we might think about transforming these PNG files into JPG files. Thanks.

@94noni
Copy link
Contributor Author

94noni commented Dec 29, 2021

I’ll compare before after and reduce size no problem

edit: I've drag&drop files into the https://squoosh.app/ and recommitted the output

@javiereguiluz
Copy link
Member

Thanks a lot for updating all these images. It's really a nice work. Thanks also for optimizing their size. The size increase now is very reasonable and caused by the higher resolution images 👍

@javiereguiluz javiereguiluz merged commit 0a17d12 into symfony:5.4 Dec 30, 2021
@94noni 94noni deleted the ft-clean-img branch December 30, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants