Skip to content

[Security] Add deprecation information for is_anonymous #16379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

malteschlueter
Copy link
Contributor

@malteschlueter malteschlueter commented Jan 8, 2022

Don't know in which issue or pr this happend but I found in the UPGRADE-5.4.md that the is_anonymous() function is deprecated. Instead the is_authenticated() function should be used.

https://github.com/symfony/symfony/blob/5.4/UPGRADE-5.4.md#security

Deprecate AuthenticationTrustResolverInterface::isAnonymous() and the is_anonymous() expression function as anonymous no longer exists in version 6, use the isFullFledged() or the new isAuthenticated() instead if you want to check if the request is (fully) authenticated

How do we handle the upmerge? The deprecation information must be removed in 6.0 and the general information about the function in line 67-70. Should I create a follow up PR?

@javiereguiluz
Copy link
Member

Thanks Malte ... and sorry it took us so long to merge this. Yes, when we merge this into upper branches, we'll remove the deprecated feature, so there's no need for other PRs. Thanks!

@javiereguiluz javiereguiluz merged commit c32d97d into symfony:5.4 Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants