[Config] Add Kernel method override example for php/xml formats #16694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @HypeMC ! Please note that I merged this in upper branches ... but removed it in 6.1 branch, where we added built-in support for YAML and PHO, so I don't think we need to display the example (only XML config is missing, and not many people are using it). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs for version 5.4 aren't clear on what needs to be updated to add support for the
xmlandphpconfig formats.With previous versions this wasn't a problem since the
Kernelclass in the recipe had aconfigureContainermethod so it was easy to infer what needs to be done. However, starting with version 5.4 the method was moved to theMicroKernelTraitand removed from the recipe making it a lot harder to know what exactly needs to be done to getphp/xmlformats working.