[Frontend] Add a note about stimulusFetch & TypeScript config #16815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
May 20, 2022
| .. note:: | ||
|
|
||
| If you write your controllers using TypeScript, make sure | ||
| ``removeComments`` is not set to ``true`` in your TypeScript config. |
There was a problem hiding this comment.
Maybe extend the sentence to explain the "why"?
There was a problem hiding this comment.
Not sure if this is necessary? I mean, the config is a comment, so it makes sense without explaining it? Or do you mean to explain that TypeScript is compiled before stimulusFetch config is handled by Simulus bridge?
weaverryan
approved these changes
May 20, 2022
maxhelias
approved these changes
May 20, 2022
|
Thank you @jmsche. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a note about using
stimulusFetchin Stimulus controllers while writing them with TypeScript.