[HttpClient] Mention extra.trace_content option
#16894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/ Cheers! Carsonbot |
|
Uh should I really rebase it on 5.4? The documentation (and PR placeholder) says
🤔 |
OskarStark
changed the title
extra.trace_content option
Yes please, as 5.2 is not maintained anymore |
|
Okay, done 👌 |
OskarStark
reviewed
Jun 18, 2022
http_client.rst
Outdated
| ~~~~~~~~~ | ||
|
|
||
| When you are using the :class:`Symfony\\Component\\HttpClient\\TraceableHttpClient` | ||
| responses content will be kept in memory, which can cause different issues. |
There was a problem hiding this comment.
Suggested change
| responses content will be kept in memory, which can cause different issues. | |
| responses, content will be kept in memory, which can cause different issues. |
OskarStark
reviewed
Jun 18, 2022
http_client.rst
Outdated
| When you are using the :class:`Symfony\\Component\\HttpClient\\TraceableHttpClient` | ||
| responses content will be kept in memory, which can cause different issues. | ||
|
|
||
| You can disable this behavior by setting the ``extra.trace_content`` to ``false`` |
There was a problem hiding this comment.
Suggested change
| You can disable this behavior by setting the ``extra.trace_content`` to ``false`` | |
| You can disable this behavior by setting the ``extra.trace_content`` option to |
OskarStark
reviewed
Jun 18, 2022
http_client.rst
Outdated
| responses content will be kept in memory, which can cause different issues. | ||
|
|
||
| You can disable this behavior by setting the ``extra.trace_content`` to ``false`` | ||
| in your requests’ options:: |
There was a problem hiding this comment.
Suggested change
| in your requests’ options:: | |
| ``false`` in your requests’ options:: |
OskarStark
reviewed
Jun 18, 2022
http_client.rst
Outdated
| 'extra' => ['trace_content' => false], | ||
| ]); | ||
|
|
||
| This setting won’t have any effect with other clients. |
There was a problem hiding this comment.
Suggested change
| This setting won’t have any effect with other clients. | |
| This setting won’t have any effect with other clients. | |
| .. versionadded:: 5.4 | |
| The ``extra.trace_content`` option was introduced in Symfony 5.2. |
|
@OskarStark thanks for the review 🙏 I changed things a little further; I hope it’s okay. |
|
Thank you @MatTheCat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14424