Skip to content

Update cookbook/security/acl.rst #1697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2012
Merged

Update cookbook/security/acl.rst #1697

merged 2 commits into from
Sep 29, 2012

Conversation

DenisGorbachev
Copy link

@iampersistent
Copy link

👍

@jmikola
Copy link
Contributor

jmikola commented Sep 10, 2012

Additionally, you should probably stick to the existing column wrap (the link will likely go on its own line).

@DenisGorbachev
Copy link
Author

Like this?

@jmikola
Copy link
Contributor

jmikola commented Sep 11, 2012

Question for @iampersistent: although you depend on the ODM bundle, you technically only require a connection from doctrine/mongodb, correct? That's the library analogous to Doctrine DBAL. If so, I suggest we rewrite the paragraph like so:

    The ACL system requires a connection from either Doctrine DBAL (usable by
    default) or Doctrine MongoDB (usable with `MongoDBAclBundle`_). However,
    that does not mean that you have to use Doctrine ORM or ODM for mapping your
    domain objects. You can use whatever mapper you like for your objects, be it
    Doctrine ORM, MongoDB ODM, Propel, raw SQL, etc. The choice is yours.

Most doc chapters define external links at the bottom of the file, so I would also suggest adding this towards the end (see doctrine.rst for an existing example):


.. _`MongoDBAclBundle`: https://github.com/IamPersistent/MongoDBAclBundle

@iampersistent
Copy link

@jmikola you are correct. In fact, it shouldn't have any dependency on the bundle. That was just some carelessness on my part when I pulled the code from the ODM Bundle. I've removed it and update the dependency to doctrine/mongodb. Thanks for catching that.

@DenisGorbachev
Copy link
Author

Should I reflect this in PR?

On Wed, Sep 12, 2012 at 8:01 AM, Richard Shank [email protected]:

@jmikola https://github.com/jmikola you are correct. In fact, it
shouldn't have any dependency on the bundle. That was just some
carelessness on my part when I pulled the code from the ODM Bundle. I've
removed it and update the dependency to doctrine/mongodb. Thanks for
catching that.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1697#issuecomment-8481383.

Денис Горбачев,
Руководитель коллектива «Быстрее ветра»
http://www.faster-than-wind.ru/
+7 919 968-00-40

weaverryan added a commit that referenced this pull request Sep 29, 2012
Update cookbook/security/acl.rst
@weaverryan weaverryan merged commit d2e40b3 into symfony:2.0 Sep 29, 2012
@jmikola
Copy link
Contributor

jmikola commented Sep 29, 2012

@iampersistent It looks like MongoDBAclBundle is still depending on ODM: https://github.com/iampersistent/MongoDBAclBundle/blob/master/composer.json

@weaverryan
Copy link
Member

Hey guys!

I've merged this in and pulled in the rewording from @jmikola

Thanks!

@iampersistent
Copy link

@jmikola I'll look at it this evening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants