-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Update cookbook/security/acl.rst #1697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👍 |
Additionally, you should probably stick to the existing column wrap (the link will likely go on its own line). |
Like this? |
Question for @iampersistent: although you depend on the ODM bundle, you technically only require a connection from doctrine/mongodb, correct? That's the library analogous to Doctrine DBAL. If so, I suggest we rewrite the paragraph like so:
Most doc chapters define external links at the bottom of the file, so I would also suggest adding this towards the end (see doctrine.rst for an existing example):
|
@jmikola you are correct. In fact, it shouldn't have any dependency on the bundle. That was just some carelessness on my part when I pulled the code from the ODM Bundle. I've removed it and update the dependency to doctrine/mongodb. Thanks for catching that. |
Should I reflect this in PR? On Wed, Sep 12, 2012 at 8:01 AM, Richard Shank [email protected]:
Денис Горбачев, |
Update cookbook/security/acl.rst
@iampersistent It looks like MongoDBAclBundle is still depending on ODM: https://github.com/iampersistent/MongoDBAclBundle/blob/master/composer.json |
Hey guys! I've merged this in and pulled in the rewording from @jmikola Thanks! |
@jmikola I'll look at it this evening |
See doctrine/DoctrineMongoDBBundle#4 (comment)