Skip to content

Update upgrade_major.rst #17076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions setup/upgrade_major.rst
Original file line number Diff line number Diff line change
Expand Up @@ -291,10 +291,10 @@ Classes in the ``vendor/`` directory are always ignored.

# Add type declarations to all internal, final, tests and private methods.
# Update the "php" parameter to match your minimum required PHP version
$ SYMFONY_DEPRECATIONS_HELPER="force=1&php=7.4" ./vendor/bin/patch-type-declarations
$ SYMFONY_PATCH_TYPE_DECLARATIONS="force=1&php=7.4" ./vendor/bin/patch-type-declarations

# Add PHPDoc to the leftover public and protected methods
$ SYMFONY_DEPRECATIONS_HELPER="force=phpdoc&php=7.4" ./vendor/bin/patch-type-declarations
$ SYMFONY_PATCH_TYPE_DECLARATIONS="force=phpdoc&php=7.4" ./vendor/bin/patch-type-declarations

After running the scripts, check your classes and add more ``@return``
PHPDoc where they are missing. The deprecations and patch script
Expand All @@ -312,7 +312,7 @@ Classes in the ``vendor/`` directory are always ignored.
.. code-block:: terminal

# Update the "php" parameter to match your minimum required PHP version
$ SYMFONY_DEPRECATIONS_HELPER="force=2&php=7.4" ./vendor/bin/patch-type-declarations
$ SYMFONY_PATCH_TYPE_DECLARATIONS="force=2&php=7.4" ./vendor/bin/patch-type-declarations

Now, you can safely allow ``^6.0`` for the Symfony dependencies.

Expand Down