[Serializer] Document support of PHP backed enumerations #17101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See this example which mention that PHP 8.0 is required: Lines 53 to 56 in 49bbf15 |
|
status: needs work |
|
friendly ping @alexislefebvre as reviewer :) |
alexislefebvre
approved these changes
Aug 3, 2022
|
Antoine, thanks for creating so many contributions for so many features! |
|
my pleasure :) |
I didn't knew that we were able to interact with the status through carsonbot. 😳 I learned something new, thanks! Should it be added to the doc of docs or kept as a secret trick? 🥷 |
|
yes it is a very intelligent bot understanding some status request 🤖 🧠 😄 |
|
@alexislefebvre I’ve seen your edit, it is documented here https://symfony.com/doc/current/contributing/community/reviews.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #15489
PS: I do not know if we should document that this requires
PHP v8.1+and if yes, how to document it