Skip to content

Avoiding the term "login form"... #17137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

ThomasLandauer
Copy link
Contributor

...since we're not talking about a "usual" login form (i.e. username+password) here.

@carsonbot carsonbot added this to the 5.4 milestone Aug 9, 2022
@javiereguiluz
Copy link
Member

There might be some small differences in semantics ... but I think that using "login form" is still correct, even if this is not a "username+password form" but a "request a link form". To me, technically speaking, both are "login forms".

Let's wait for more opinions about this. E.g. @wouterj or @OskarStark

@ThomasLandauer
Copy link
Contributor Author

ThomasLandauer commented Oct 19, 2022

I have two arguments:

  1. Technical: Requesting a link doesn't log somebody in. The login is done by clicking the link in the email. So I wouldn't call it a "login form".
  2. Consistency: At https://symfony.com/doc/current/security.html#form-login you're using the term "login form" in its classic meaning. So if you see the "request link form" as "login form" too, you'd need to call the former a "login form with username and password" - as opposed to a "login form to request a link" ;-)

@javiereguiluz javiereguiluz added Waiting team decision Request for comments from Symfony Docs Team members and removed Waiting feedback labels Oct 21, 2022
@javiereguiluz javiereguiluz added Status: Reviewed and removed Status: Needs Review Waiting team decision Request for comments from Symfony Docs Team members labels Jan 18, 2024
@javiereguiluz
Copy link
Member

After re-reading this proposal, I think you are right so I just merged it. Thanks Thomas!

@ThomasLandauer ThomasLandauer deleted the patch-18 branch January 18, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants