Skip to content

[Cache] Add use Response & return hint #17188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2022
Merged

[Cache] Add use Response & return hint #17188

merged 1 commit into from
Aug 21, 2022

Conversation

mohamedGasmii
Copy link
Contributor

No description provided.

@carsonbot carsonbot added this to the 5.4 milestone Aug 16, 2022
@wouterj wouterj changed the base branch from 5.4 to 4.4 August 21, 2022 11:41
@wouterj wouterj requested a review from xabbuh as a code owner August 21, 2022 11:41
@wouterj
Copy link
Member

wouterj commented Aug 21, 2022

Thank you @mohamedGasmii! Fyi, I've merged this in 4.4 (these types were valid in PHP 7.1) and I'll merge it up to the newer versions from there.

@wouterj wouterj merged commit 25428e8 into symfony:4.4 Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Cache Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@mohamedGasmii @wouterj @OskarStark @carsonbot