Skip to content

[Console] Remove $defaultName #17224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2022
Merged

[Console] Remove $defaultName #17224

merged 1 commit into from
Sep 19, 2022

Conversation

mohamedGasmii
Copy link
Contributor

Remove $defaultName and add clarification in the comment

@mohamedGasmii
[Console] Remove $defaultName
e343163 
Remove $defaultName and add clarification in the comment
@javiereguiluz javiereguiluz added this to the 6.1 milestone Sep 19, 2022
@javiereguiluz javiereguiluz merged commit 8decc93 into symfony:6.1 Sep 19, 2022
@javiereguiluz
Copy link
Member

Thanks @mohamedGasmii. While merging I removed the comment about protected static $defaultName for consistency, because in the rest of the docs we just use #[AsCommand] without mentioning the old $defaultName property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Console Status: Reviewed
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@mohamedGasmii @javiereguiluz @carsonbot