[Security] Added documentation for IS_AUTHENTICATED #17226
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that this part of the doc is wrong or might be confusing. In order to check if the user is simply logged in, they are suggesting using the
IS_AUTHENTICATED_FULLY
attribute. But later below, we learn that this attribute is the "stronger" one and that it cannot be used in that context because:So the appropriate attribute should have been
IS_AUTHENTICATED_REMEMBERED
:But unfortunately, its name is misleading and it took me some long minutes to understand it and why it has been named like that.
After digging into the AuthenticatedVoter for a better understanding of these attributes, I stumbled upon an undocumented attribute called
IS_AUTHENTICATED
.I believe that this attribute should be present in the doc and should become the recommended one when checking if a user is simply logged in because its name is obviously clearer and better describes its intent.
I'm not sure why it's not documented but it has been brought by this symfony/symfony@e3aca7f.