Skip to content

[DependencyInjection] Fix docs referencing an incorrect PHP function #17298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2022
Merged

[DependencyInjection] Fix docs referencing an incorrect PHP function #17298

merged 1 commit into from
Sep 27, 2022

Conversation

Toflar
Copy link
Contributor

@Toflar Toflar commented Sep 27, 2022

Looks like some leftover? At least, there is no ref function 🤔

HeahDude
HeahDude approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Should target 5.4 if possible (ref has been deprecated in Symfony 5)

@javiereguiluz javiereguiluz added this to the 5.4 milestone Sep 27, 2022
@carsonbot carsonbot changed the title Fix docs referencing an incorrect PHP function [DependencyInjection] Fix docs referencing an incorrect PHP function Sep 27, 2022
@javiereguiluz javiereguiluz changed the base branch from 6.1 to 5.4 September 27, 2022 14:41
@javiereguiluz javiereguiluz merged commit 46c036d into symfony:5.4 Sep 27, 2022
@Toflar Toflar deleted the patch-3 branch September 27, 2022 14:42
@javiereguiluz
Copy link
Member

Thank you Yanick! Note: this was merged in 5.4 branch and up.

@Toflar
Copy link
Contributor Author

Toflar commented Sep 27, 2022

Thanks for taking over, Javier! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeahDude HeahDude HeahDude approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
DependencyInjection Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@Toflar @javiereguiluz @HeahDude @carsonbot