Skip to content

[Messenger] Removing note docblock for MessageHandlerInterface #17332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

mdoutreluingne
Copy link
Contributor

@mdoutreluingne mdoutreluingne commented Oct 8, 2022

The docblock note is no longer necessary required from Symfony 6.0 onwards as it requires PHP 8.0.

What do you think?

The docblock note is no longer required from Symfony 6.0 onwards as it requires PHP 8.0.
Copy link
Contributor

@94noni 94noni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sens

@javiereguiluz
Copy link
Member

Thank you Maxime.

@javiereguiluz javiereguiluz merged commit 5a02dc1 into symfony:6.0 Oct 10, 2022
@mdoutreluingne mdoutreluingne deleted the patch-1 branch October 10, 2022 16:04
javiereguiluz added a commit that referenced this pull request Oct 11, 2022
…treluingne)

This PR was squashed before being merged into the 6.2 branch.

Discussion
----------

[Messenger] Deprecate `MessageSubscriberInterface`

Fixes #17319

For `MessageHandlerInterface` class, it's not necessary to create a deprecation directive because we display it more since Symfony 5.3 in Symfony doc. I have created a PR #17332 for removing note block as it is no longer necessary in Symfony 6.0.

Commits
-------

cb957d7 [Messenger] Deprecate `MessageSubscriberInterface`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants