Fixing line length to avoid horizontal scrolling in DI component #1744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -128,14 +128,24 @@ custom tag:: | |||
| { | |||
| public function process(ContainerBuilder $container) | |||
| { | |||
| if (false === $container->hasDefinition('acme_mailer.transport_chain')) { | |||
| if (false === $container->hasDefinition( | |||
There was a problem hiding this comment.
you could change it to if (!container->hasDefinition()) { instead of false ===. It would follow the Sf2 CS and save 9 chars in the line
There was a problem hiding this comment.
Good point, updated, thanks.
weaverryan
added a commit
that referenced
this pull request
Oct 7, 2012
Fixing line length to avoid horizontal scrolling in DI component
|
Love it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.