Skip to content

[Validator] enable_annotations also read attributes #17473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2022
Merged

[Validator] enable_annotations also read attributes #17473

merged 1 commit into from
Dec 8, 2022
+2 −2

Conversation

alamirault
Copy link
Contributor

@alamirault alamirault commented Nov 27, 2022 •
edited
Loading

AnnotationLoader doc tell attributes are read but in enable_annotations reference it's not said

@carsonbot carsonbot added this to the 6.2 milestone Nov 27, 2022
@OskarStark OskarStark changed the title enable_annotations read also attributes enable_annotations also read attributes Nov 28, 2022
@wouterj wouterj modified the milestones: 6.2, 5.4 Nov 29, 2022
@carsonbot carsonbot changed the title enable_annotations also read attributes [Validator] enable_annotations also read attributes Dec 8, 2022
@javiereguiluz javiereguiluz changed the base branch from 6.2 to 5.4 December 8, 2022 16:36
@javiereguiluz javiereguiluz force-pushed the hotfix/enable-annotations-attribute branch from 085d9fd to c654ef8 Compare December 8, 2022 16:36
@javiereguiluz
Copy link
Member

Thanks Antoine.

@javiereguiluz javiereguiluz merged commit f5bac22 into symfony:5.4 Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed Validator
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@alamirault @javiereguiluz @wouterj @carsonbot