Skip to content

Text corrections #17527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Text corrections #17527

merged 1 commit into from
Dec 7, 2022

Conversation

dragonito
Copy link
Contributor

Some text corrections

@javiereguiluz javiereguiluz changed the base branch from 6.2 to 5.4 December 7, 2022 16:59
@javiereguiluz javiereguiluz requested a review from xabbuh as a code owner December 7, 2022 16:59
@javiereguiluz javiereguiluz merged commit 73241ee into symfony:5.4 Dec 7, 2022
@javiereguiluz
Copy link
Member

Robin, thanks for this improvements.

Please note that while merging I reverted the change that added a , after e.g. You are technically right (as explained in https://jakubmarian.com/comma-after-i-e-and-e-g/), but we have lots of e.g. examples in the docs and we can't change all of them (please, nobody create a Pull Request for this because it won't be merged because of the great effort needed from contributors to do so across all branches). So, given that not adding a comma is OK for British English and for some of American English, let's keep it like that. Thanks for understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants