[Security] Make login redirection logic available to programmatic login #17556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellomedia
changed the title
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Dec 21, 2022
…rogrammatic login (hellomedia) This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [Security] Make login redirection logic available to programmatic login | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no | Tickets | - | License | MIT | Doc PR | [17556](symfony/symfony-docs#17556) The `Security::login()` method [introduced in 6.2](https://github.com/symfony/symfony/pull/41274/files) returns `void`, whereas `UserAuthenticator::authenticateUser()` called under the hood returns a response which can be used to redirect the user. This PR makes `login()` return the response from `authenticateUser()`, allowing the regular login redirection logic to be used if needed. **Usage** ````php use Symfony\Bundle\FrameworkBundle\Controller\AbstractController; use Symfony\Bundle\SecurityBundle\Security; use Symfony\Component\HttpFoundation\Response; class RegistrationController extends AbstractController { public function verifyUserEmail(Security $security): Response { ... $redirectResponse = $security->login($user); return $redirectResponse; } } ```` **TODO** - test - update CHANGELOG ? Commits ------- 568191f [Security] Make login redirection logic available to programmatic login
carsonbot
changed the title
|
Thanks Nicolas ... and sorry it took us so long to merge your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make regular login redirection logic available in programmatic login as proposed in symfony/symfony#48582 .
User can ignore the redirectResponse and implement its own redirection logic.