Skip to content

Symfony CLI: fix config directory path #17560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2022
Merged

Symfony CLI: fix config directory path #17560

merged 1 commit into from
Dec 16, 2022

Conversation

jmsche
Copy link
Contributor

@jmsche jmsche commented Dec 14, 2022

Symfony CLI config directory changed when Symfony CLI 5 was released, hence this change.

@jmsche jmsche changed the base branch from 6.2 to 5.4 December 14, 2022 14:21
@javiereguiluz
Copy link
Member

@jmsche the directory name is symfony6 for Symfony 6 versions?

@javiereguiluz javiereguiluz added this to the 5.4 milestone Dec 14, 2022
@jmsche
Copy link
Contributor Author

jmsche commented Dec 14, 2022 •
edited
Loading

@javiereguiluz No, seems related to CLI version

see https://github.com/symfony-cli/symfony-cli/blob/48ca923fa3adc2e725788626f02501dff52ddc6a/util/util.go#L30

@javiereguiluz
Copy link
Member

Thanks for reviewing this and for confirming me that I don't have to change this value when upmerging to 6.x branches.

@javiereguiluz javiereguiluz merged commit 7017e75 into symfony:5.4 Dec 16, 2022
@jmsche jmsche deleted the symfony_cli_path branch February 20, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tucksaun tucksaun tucksaun approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@jmsche @javiereguiluz @tucksaun @carsonbot