Sessions refactoring #17649
Merged
Sessions refactoring #17649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
force-pushed
the
sessions-refactoring
branch
2 times, most recently
from
ab3fbf0 to
6b46309
Compare
OskarStark
reviewed
Jan 4, 2023
|
@javiereguiluz I'd like to not wait too much before merging this one as updating it will be a pain if we merge something in the related files. |
wouterj
approved these changes
Jan 6, 2023
fabpot
force-pushed
the
sessions-refactoring
branch
3 times, most recently
from
a698810 to
0c35171
Compare
|
I think I've taken all comments into accounts. |
dbrumann
reviewed
Jan 6, 2023
dbrumann
approved these changes
Jan 6, 2023
|
Hopefully, we're good now. We will refactor the content more if needed later on. |
wouterj
force-pushed
the
sessions-refactoring
branch
from
b046f5a to
0c5fe69
Compare
|
Thanks @HeahDude for the review, I've applied your suggestions during the merge. As requested, let's merge this PR now. If someone still has some comments, please open a PR with the changes and we can merge it :) @fabpot while merging this in newer versions, I've moved a new subarticle into the main one at 9eb7378 Please have a look if you think this is a relevant addition to the main guide :) |
|
Thank you @wouterj for the fast merge and thank you all for your reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my modest attempt to merge everything related to the session into one document.
It's hard as much information was duplicated in several docs.
I hope you will like it.