-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[2.2] Console Component Progress Documenation #1765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[Form] Update the Form related documentation
to $entityManager = $args->getEntityManager();
Updated the doc for symfony/symfony#4497
[Form] Add doc for the escape_label option
Conflicts: reference/configuration/web_profiler.rst
Fixed syntax
Add Filesystem component documentation
…type') instead of get('prototype')
… getVar('prototype') instead of get('prototype')
This looks funny to me... shouldn't this be an adverb (I'm not sure, I'm not a native english speaker)?
Conflicts: components/routing.rst
.. versionadded:: 2.2 | ||
The ``progress`` helper was added in Symfony 2.2. | ||
|
||
When executing longer-running commands, it may be helpful to to show progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to to show
=> to show
Nice work. thanks. |
|
||
$progress->setFormat(ProgressHelper::QUIET); | ||
$progress->setFormat(ProgressHelper::NORMAL); | ||
$progress->setFormat(ProgressHelper::VERBOSE); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong constant names. FORMAT_
is missing
The code is neater if we use the dedicated method available in the Request class
field_label, field_widget, field_errors and fields_row are deprecated in sf 2.1
$progress->start($output, 50); | ||
$i = 0; | ||
while ($i++ < 50) { | ||
// do some work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be // ... do some work
fixing examples of in_memory provider, "memory" key was missing
Conflicts: book/doctrine.rst
Changes from use Symfony\Component\Security\Core\Validator\Constraints as SecurityAssert; to use Symfony\Component\Security\Core\Validator\Constraint as SecurityAssert;
Hi guys!
This supports symfony/symfony#3501, and more specifically the further changes made on the progress-helper branch: https://github.com/symfony/symfony/tree/progress-helper
Thanks!