Skip to content

[2.2] Console Component Progress Documenation #1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 609 commits into from
Oct 7, 2012

Conversation

weaverryan
Copy link
Member

Hi guys!

This supports symfony/symfony#3501, and more specifically the further changes made on the progress-helper branch: https://github.com/symfony/symfony/tree/progress-helper

Thanks!

weaverryan and others added 30 commits June 14, 2012 06:00
[Form] Update the Form related documentation
to
$entityManager = $args->getEntityManager();
[Form] Add doc for the escape_label option
This reverts commit 7250391.

See #1440 for details on the revert
Conflicts:
	reference/configuration/web_profiler.rst
Add Filesystem component documentation
… getVar('prototype') instead of get('prototype')
weaverryan and others added 7 commits September 22, 2012 15:19
This looks funny to me... shouldn't this be an adverb (I'm not sure, I'm not a native english speaker)?
Conflicts:
	components/routing.rst
.. versionadded:: 2.2
The ``progress`` helper was added in Symfony 2.2.

When executing longer-running commands, it may be helpful to to show progress
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to to show => to show

@lyrixx
Copy link
Member

lyrixx commented Sep 29, 2012

Nice work. thanks.


$progress->setFormat(ProgressHelper::QUIET);
$progress->setFormat(ProgressHelper::NORMAL);
$progress->setFormat(ProgressHelper::VERBOSE);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong constant names. FORMAT_ is missing

$progress->start($output, 50);
$i = 0;
while ($i++ < 50) {
// do some work
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be // ... do some work

weaverryan and others added 7 commits October 6, 2012 21:33
fixing examples of in_memory provider, "memory" key was missing 
Conflicts:
	book/doctrine.rst
Changes from 
    use Symfony\Component\Security\Core\Validator\Constraints as SecurityAssert;
to 
    use Symfony\Component\Security\Core\Validator\Constraint as SecurityAssert;
@weaverryan weaverryan merged commit bf1a6b3 into master Oct 7, 2012
@weaverryan
Copy link
Member Author

Hi guys!

I've made the few tweaks you mentioned and merged this into master. The PR, however, seems to have exploded a bit on GitHub after rebasing :/. But, the actual merge was very simple in reality:

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.