Add YAML encoder to serializer diagram #17650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndench
approved these changes
Jun 11, 2023
|
@l-vo I'm sorry it took us so long to review this. The font used in diagrams is called "PT Sans Narrow", which is free and open source. You can get the font and check other important things about diagrams, here: Thanks! |
l-vo
force-pushed
the
add_yaml_serializer_diagram
branch
from
fce0bb8 to
a0ecf18
Compare
|
@javiereguiluz thank you 🙂 I totally missed this page of documentation. I updated the graph with the right font (that is not the same as the original one but I guess the "official" font was not chosen at the time the graph was created). |
xabbuh
approved these changes
Jun 24, 2023
javiereguiluz
approved these changes
Jun 24, 2023
|
This is finally merged! Thanks Laurent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add YAML encoder to serializer diagram.
@javiereguiluz the font is not the same because I don't have the font you originally used, do you have it ?