Skip to content

Set engine=php with Template annotation #1766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Set engine=php with Template annotation #1766

wants to merge 1 commit into from

Conversation

tvlooy
Copy link
Contributor

@tvlooy tvlooy commented Sep 30, 2012

No description provided.

@richardmiller-zz
Copy link
Contributor

There is no mention of the Template notation on this page so it seems strange to introduce it here. It may be worth adding a mention of it earlier that links to the SensioFrameworkExtraBundle documentation for it so that it is not a new concept at this point. This note could also link through to that documentation as well as the FrameworkExtra annotations are generally documented there and just linked to through from the book pages.

@weaverryan
Copy link
Member

Hi Tom!

I agree with @richardmiller that this doesn't seem like quite the right place for this. BUT, since this is an article that's all about using PHP templates in Symfony, I think it's actually quite practical to add it here. So, I've patched your commit into the 2.0 branch at sha: b68f6d6 and added a few tweaks at sha: 7d03a92, including a link to the docs in SensioFrameworkExtraBundle.

Thanks!

@weaverryan weaverryan closed this Oct 31, 2012
@wouterj
Copy link
Member

wouterj commented Oct 31, 2012

This actually is documented in the SensioFrameworkExtraBundle since the 2.1 branch, I just posted a comment to get it also in the 2.0 branch.

I think it isn't needed to explain it here, as it isn't documented for Twig (we could add it to book/templating or book/controller, but we didn't). It is maybe better to add a tip block, something like:

.. tip::

    You can also use the :doc:`/bundes/SensioFrameworkExtraBundle/annotation/view` 
    annotation to render a template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants