Standardize the name of the container configurator variable #17664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamirault
commented
Jan 5, 2023
Comment on lines
-236
to
-237
| return static function (ContainerConfigurator $container) { | ||
| $services = $configurator->services(); |
There was a problem hiding this comment.
Found some places where variables does not match, $container injected but $configurator used.
wouterj
approved these changes
Jan 6, 2023
xabbuh
approved these changes
Jan 6, 2023
|
Thank you Antoine. |
alamirault
deleted the
feature/17381-standardize-container-configurator-variable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17381
Use always
ContainerConfigurator $containerConfiguratorinstead of$containeror$configurator