[Config] Introducing the new param() function as early as possible
#17673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamirault
reviewed
Jan 6, 2023
configuration.rst
Outdated
|
|
||
| return static function (ContainerConfigurator $containerConfigurator) { | ||
| $containerConfigurator->extension('some_package', [ | ||
| // any string surrounded by two % is replaced by that parameter value |
There was a problem hiding this comment.
Keep comment for %% case ? Like for xml and yaml
There was a problem hiding this comment.
Two counter-arguments:
- (More important): It's explained right above the code block:
wrap the parameter name in two % (e.g. %app.admin_email%):
- (Less important): In PHP,
env()should be shown as preferred way (IMO).
94noni
approved these changes
May 27, 2023
carsonbot
changed the title
param() function as early as possibleparam() function as early as possible
|
Thank you Thomas. |
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Jun 6, 2023
…s early as possible (ThomasLandauer) This PR was squashed before being merged into the 5.4 branch. Discussion ---------- [Config] Introducing the new `param()` function as early as possible Commits ------- a4c1261 [Config] Introducing the new `param()` function as early as possible
|
Note: GitHub displays this PR as "closed", but it was fully merged. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.