[Security] Remember me JSON Login #17676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
added
the
Waiting Code Merge
chalasr
added a commit
to symfony/symfony
that referenced
this pull request
Feb 24, 2023
…merdev, nicolas-grekas) This PR was merged into the 6.3 branch. Discussion ---------- [Security] Add remember me option for JSON logins | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #40918 | License | MIT | Doc PR | symfony/symfony-docs#17676 This resolves the above mentioned issue by adding a `RememberMeBadge` to `JsonLoginAuthenticator` and by extending `CheckRememberMeConditionsListener` to be able to read the remember me parameter from a JSON request body (if reading from ParameterBag was unsuccessful). This means you can send a JSON request with a body like this and needn‘t use a fallback HTTP form login when building your API: ```json { "username": "dunglas", "password": "MyPassword", "_remember_me": true } ```` Commits ------- 5fe525f [Security] Allow passing remember-me parameters via RememberMeBadge e78461e [Security] Add remember me option for JSON logins
javiereguiluz
added
Status: Reviewed
and removed
Status: Needs Review
Waiting Code Merge
|
Markus, thanks a lot for contributing this feature and the docs for it. Congrats also on your first Symfony Docs contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add block with description, how to set up remember me functionality for JSON Login
Issue symfony/symfony#40918
Pull Request symfony/symfony#48899