[Validator] Add the option filenameMaxLength to the File constraint
#17955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdoutreluingne
approved these changes
Feb 22, 2023
ke20
approved these changes
Feb 22, 2023
|
|
||
| The message displayed if the filename of the file exceeds the limit set | ||
| with the ``filenameMaxLength`` option. | ||
|
|
There was a problem hiding this comment.
I think you can add :
You can use the following parameters in this message:
============================== ==============================================================
Parameter Description
============================== ==============================================================
``{{ filename_max_length }}`` Maximum number of characters allowed
============================== ==============================================================I saw some similar thing for other options.
Thanks for the PR :)
There was a problem hiding this comment.
Oooh yeah definitely. Thank you!
alexandre-daubois
force-pushed
the
filenamelength-constraint
branch
from
48243ec to
83fb4d4
Compare
ke20
reviewed
Feb 23, 2023
reference/constraints/File.rst
Outdated
| ``filenameMaxLength`` | ||
| ~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| **type**: ``int`` **default**: ``null`` |
There was a problem hiding this comment.
Suggested change
| **type**: ``int`` **default**: ``null`` | |
| **type**: ``integer`` **default**: ``null`` |
There was a problem hiding this comment.
This should be spotted by DOCtor-RST 🤔 , was this the case?
There was a problem hiding this comment.
Just checked. It was spotted, I just missed it 😄
https://github.com/symfony/symfony-docs/actions/runs/4245728234/jobs/7381615847
alexandre-daubois
force-pushed
the
filenamelength-constraint
branch
from
83fb4d4 to
1a1fb8f
Compare
OskarStark
approved these changes
Feb 27, 2023
|
Thank you Alexandre. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17953