[HttpClient] Replace a few classes and methods occurrences by their source code link #17988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Mar 2, 2023
OskarStark
reviewed
Mar 2, 2023
OskarStark
reviewed
Mar 2, 2023
alexandre-daubois
force-pushed
the
httpclient-classes-methods
branch
4 times, most recently
from
dd9fc9f to
394fc95
Compare
OskarStark
reviewed
Mar 2, 2023
alexandre-daubois
force-pushed
the
httpclient-classes-methods
branch
2 times, most recently
from
3f4b3c7 to
ea53c03
Compare
OskarStark
approved these changes
Mar 3, 2023
wouterj
reviewed
Mar 3, 2023
http_client.rst
Outdated
| @@ -1041,8 +1044,9 @@ following methods:: | |||
| Streaming Responses | |||
| ~~~~~~~~~~~~~~~~~~~ | |||
|
|
|||
| Call the ``stream()`` method of the HTTP client to get *chunks* of the | |||
| response sequentially instead of waiting for the entire response:: | |||
| Call the ``stream()`` method of :class:`Symfony\\Contracts\\HttpClient\\HttpClientInterface` | |||
There was a problem hiding this comment.
Suggested change
| Call the ``stream()`` method of :class:`Symfony\\Contracts\\HttpClient\\HttpClientInterface` | |
| Call the :class:`Symfony\\Contracts\\HttpClient\\HttpClientInterface::stream`` method |
Same for similar occurrences.
There was a problem hiding this comment.
Updated for this one and other occurrences 🙂
http_client.rst
Outdated
| ``HttpClient::create()`` selects the cURL transport if the `cURL PHP extension`_ | ||
| is enabled and falls back to PHP streams otherwise. If you prefer to select | ||
| the transport explicitly, use the following classes to create the client:: | ||
| The ``create()`` method of :class:`Symfony\\Component\\HttpClient\\HttpClient` |
There was a problem hiding this comment.
Suggested change
| The ``create()`` method of :class:`Symfony\\Component\\HttpClient\\HttpClient` | |
| :class:`HttpClient::create() <Symfony\\Component\\HttpClient\\HttpClient::create>` |
There was a problem hiding this comment.
IMHO we should keep HttpClient::create() like before, same for the other examples
wouterj
reviewed
Mar 3, 2023
alexandre-daubois
force-pushed
the
httpclient-classes-methods
branch
from
ea53c03 to
bed01f4
Compare
alexandre-daubois
force-pushed
the
httpclient-classes-methods
branch
from
bed01f4 to
335c8cf
Compare
|
Forgot this one 😄 I updated with your suggestions |
|
Thanks Alex ... and thanks reviewers too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a few missing ones