Skip to content

Upgrade doctor rst 1.41.3 #18052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ jobs:
key: ${{ runner.os }}-doctor-rst-${{ steps.extract_base_branch.outputs.branch }}

- name: "Run DOCtor-RST"
uses: docker://oskarstark/doctor-rst:1.41.0
uses: docker://oskarstark/doctor-rst:1.41.3
with:
args: --short --error-format=github --cache-file=/github/workspace/.cache/doctor-rst.cache

Expand Down
17 changes: 0 additions & 17 deletions components/runtime.rst
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ The Runtime component abstracts most bootstrapping logic as so-called
For instance, the Runtime component allows Symfony's ``public/index.php``
to look like this::

<?php
// public/index.php
use App\Kernel;

Expand Down Expand Up @@ -120,7 +119,6 @@ Resolvable Arguments

The closure returned from the front-controller may have zero or more arguments::

<?php
// public/index.php
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
Expand Down Expand Up @@ -167,7 +165,6 @@ Resolvable Applications
The application returned by the closure below is a Symfony Kernel. However,
a number of different applications are supported::

<?php
// public/index.php
use App\Kernel;

Expand All @@ -187,7 +184,6 @@ The ``SymfonyRuntime`` can handle these applications:
The Response will be printed by
:class:`Symfony\\Component\\Runtime\\Runner\\Symfony\\ResponseRunner`::

<?php
// public/index.php
use Symfony\Component\HttpFoundation\Response;

Expand All @@ -201,8 +197,6 @@ The ``SymfonyRuntime`` can handle these applications:
To write single command applications. This will use the
:class:`Symfony\\Component\\Runtime\\Runner\\Symfony\\ConsoleApplicationRunner`::

<?php

use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
Expand All @@ -221,8 +215,6 @@ The ``SymfonyRuntime`` can handle these applications:
Useful with console applications with more than one command. This will use the
:class:`Symfony\\Component\\Runtime\\Runner\\Symfony\\ConsoleApplicationRunner`::

<?php

use Symfony\Component\Console\Application;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
Expand Down Expand Up @@ -250,7 +242,6 @@ applications:
The ``RunnerInterface`` is a way to use a custom application with the
generic Runtime::

<?php
// public/index.php
use Symfony\Component\Runtime\RunnerInterface;

Expand All @@ -271,9 +262,7 @@ applications:
Your "application" can also be a ``callable``. The first callable will return
the "application" and the second callable is the "application" itself::

<?php
// public/index.php

require_once dirname(__DIR__).'/vendor/autoload_runtime.php';

return function () {
Expand All @@ -290,8 +279,6 @@ applications:
If the callable doesn't return anything, the ``SymfonyRuntime`` will assume
everything is fine::

<?php

require_once dirname(__DIR__).'/vendor/autoload_runtime.php';

return function () {
Expand All @@ -304,8 +291,6 @@ Using Options
Some behavior of the Runtimes can be modified through runtime options. They
can be set using the ``APP_RUNTIME_OPTIONS`` environment variable::

<?php

$_SERVER['APP_RUNTIME_OPTIONS'] = [
'project_dir' => '/var/task',
];
Expand Down Expand Up @@ -496,8 +481,6 @@ always using this ``ReactPHPRunner``::

The end user will now be able to create front controller like::

<?php

require_once dirname(__DIR__).'/vendor/autoload_runtime.php';

return function (array $context) {
Expand Down
10 changes: 2 additions & 8 deletions components/uid.rst
Original file line number Diff line number Diff line change
Expand Up @@ -128,17 +128,15 @@ configure the behavior of the factory using configuration files::
.. code-block:: php

// config/packages/uid.php
<?php

namespace Symfony\Component\DependencyInjection\Loader\Configurator;

return static function (ContainerConfigurator $containerConfigurator): void {
$services = $configurator->services()
$services = $containerConfigurator->services()
->defaults()
->autowire()
->autoconfigure();

$configurator->extension('framework', [
$containerConfigurator->extension('framework', [
'uid' => [
'default_uuid_version' => 6,
'name_based_uuid_version' => 5,
Expand All @@ -152,8 +150,6 @@ configure the behavior of the factory using configuration files::
Then, you can inject the factory in your services and use it to generate UUIDs based
on the configuration you defined::

<?php

namespace App\Service;

use Symfony\Component\Uid\Factory\UuidFactory;
Expand Down Expand Up @@ -367,8 +363,6 @@ following methods to create a ``Ulid`` object from it::

Like UUIDs, ULIDs have their own factory, ``UlidFactory``, that can be used to generate them::

<?php

namespace App\Service;

use Symfony\Component\Uid\Factory\UlidFactory;
Expand Down
1 change: 0 additions & 1 deletion components/var_exporter.rst
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ following class hierarchy::
When exporting the ``ConcreteClass`` data with VarExporter, the generated PHP
file looks like this::

<?php
return \Symfony\Component\VarExporter\Internal\Hydrator::hydrate(
$o = [
clone (\Symfony\Component\VarExporter\Internal\Registry::$prototypes['Symfony\\Component\\VarExporter\\Tests\\ConcreteClass'] ?? \Symfony\Component\VarExporter\Internal\Registry::p('Symfony\\Component\\VarExporter\\Tests\\ConcreteClass')),
Expand Down
1 change: 0 additions & 1 deletion page_creation.rst
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ Suppose you want to create a page - ``/lucky/number`` - that generates a lucky (
random) number and prints it. To do that, create a "Controller" class and a
"controller" method inside of it::

<?php
// src/Controller/LuckyController.php
namespace App\Controller;

Expand Down
2 changes: 0 additions & 2 deletions quick_tour/flex_recipes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,6 @@ Rich API Support

Are you building an API? You can already return JSON from any controller::

<?php
// src/Controller/DefaultController.php
namespace App\Controller;

Expand Down Expand Up @@ -191,7 +190,6 @@ But like usual, we can immediately start using the new library. Want to create a
rich API for a ``product`` table? Create a ``Product`` entity and give it the
``@ApiResource()`` annotation::

<?php
// src/Entity/Product.php
namespace App\Entity;

Expand Down
4 changes: 0 additions & 4 deletions quick_tour/the_architecture.rst
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ Want a logging system? No problem:
This installs and configures (via a recipe) the powerful `Monolog`_ library. To
use the logger in a controller, add a new argument type-hinted with ``LoggerInterface``::

<?php
// src/Controller/DefaultController.php
namespace App\Controller;

Expand Down Expand Up @@ -87,7 +86,6 @@ To keep your code organized, you can even create your own services! Suppose you
want to generate a random greeting (e.g. "Hello", "Yo", etc). Instead of putting
this code directly in your controller, create a new class::

<?php
// src/GreetingGenerator.php
namespace App;

Expand All @@ -104,7 +102,6 @@ this code directly in your controller, create a new class::

Great! You can use this immediately in your controller::

<?php
// src/Controller/DefaultController.php
namespace App\Controller;

Expand Down Expand Up @@ -168,7 +165,6 @@ by creating an event subscriber or a security voter for complex authorization
rules. Let's add a new filter to Twig called ``greet``. How? Create a class
that extends ``AbstractExtension``::

<?php
// src/Twig/GreetExtension.php
namespace App\Twig;

Expand Down
2 changes: 0 additions & 2 deletions quick_tour/the_big_picture.rst
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ doesn't exist yet, so let's create it!
In ``src/Controller``, create a new ``DefaultController`` class and an ``index``
method inside::

<?php
// src/Controller/DefaultController.php
namespace App\Controller;

Expand Down Expand Up @@ -176,7 +175,6 @@ This works just like before! But by using annotations, the route and controller
live right next to each other. Need another page? Add another route and method
in ``DefaultController``::

<?php
// src/Controller/DefaultController.php
namespace App\Controller;

Expand Down