[Form] Added documentation for Form Type Extensions #1806
Conversation
| Form type extensions have 2 main use cases: | ||
|
|
||
| #. You want to add a **generic feature to several types** (such as | ||
| adding a "help" text to every field type) |
There was a problem hiding this comment.
Put a semicolon at the end of this item
|
@wouterj Ok, I will manage to find some more time to take your remarks into account. However, I'm a bit surprised by the additional remarks as this PR is simply a port of #1691, that had already been reviewed by you and Stof, and validated by @weaverryan. |
|
@pvanliefland Proofreading the doc is an iterative process. We regularly miss things in PRs when proofreading them (which is why there is regularly PRs fixing typos in the doc when someone else reads it). |
|
@stof I understand, but some of the remarks that have been made could be integrated in the "contributing" section, it would save people like me a lot of time. In fact I might do a PR on this one as well ;) Anyway, the changes have been implemented. |
|
Let me know when everything is ok so that I can squash everything into a single commit. |
| <?php echo $view['form']->widget($form) ?> | ||
| <?php if (null !== $image_url): ?> | ||
| <img src="<?php echo $view['assets']->getUrl($image_url) ?>"/> | ||
| <?php endif ?> |
There was a problem hiding this comment.
The 2 examples are now different, it should be better if those are equal but in another syntax.
|
@pvanliefland I have created a 'Standards' section in the documentation contribution section, just because they save me and @stof a lot of time too... We can't describe everything inside the standards, so I have putted the main rules in it. The empty lines between the bracket and the first method is a Coding Standard rule and things like the semi colons are English (and Dutch) spelling rules. But if you have suggestions to put in the standards, please create a PR! |
|
Hey Pierre! This is really really nice work! I've merged this in with only a few minor changes at sha: 88f7b5e I also used your work on #1691 to update the entry then for 2.1 - you can see that work at sha: 28ea82b Please double-check my work and let me know if you see anything that I've missed! Thanks! |
|
Hello Ryan, Thanks, I'm glad you merged it. It has been harder than I expected, but it was an interesting experience. I checked your changes, both here and for the 2.1 version and they look ok to me. Cheers and thanks for your assistance, Pierre |
This pull request is based on #1691. See issue #814. The text and examples have been adapted and tested for Symfony 2.0.x.