Skip to content

[Cache] Add documentation for new --all option for cache:pool:clear #18072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

bobvandevijver
Copy link
Contributor

Documentation update for symfony/symfony#49705.

@carsonbot carsonbot added this to the 6.3 milestone Mar 17, 2023
@OskarStark OskarStark added the Waiting Code Merge Docs for features pending to be merged label Mar 17, 2023
@carsonbot carsonbot modified the milestones: 6.3, next Mar 17, 2023
fabpot added a commit to symfony/symfony that referenced this pull request Mar 25, 2023
…e pools (bobvandevijver)

This PR was squashed before being merged into the 6.3 branch.

Discussion
----------

[FrameworkBundle] Add support to easily clear all cache pools

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | yes <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #22047<!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#18072 <!-- required for new features -->
<!--
Replace this notice by a short README for your feature/bugfix.
This will help reviewers and should be a good start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the latest branch.
 - For new features, provide some code snippets to help understand usage.
 - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
 - Never break backward compatibility (see https://symfony.com/bc).
-->

As suggested in #22047, I've now added a `--all` option to clear all cache pools by just providing that argument to `cache:pool:clear`. I believe this is more convenient than remembering the `cache.global_clearer` clearer alias and more descriptive for the consumer.

Commits
-------

3a50d2d [FrameworkBundle] Add support to easily clear all cache pools
@OskarStark OskarStark removed the Waiting Code Merge Docs for features pending to be merged label Mar 26, 2023
@OskarStark OskarStark changed the title Add documentation for new --all option for cache:pool:clear Add documentation for new --all option for cache:pool:clear Mar 26, 2023
@carsonbot carsonbot changed the title Add documentation for new --all option for cache:pool:clear [Cache] Add documentation for new --all option for cache:pool:clear Mar 29, 2023
@javiereguiluz javiereguiluz merged commit 8385b93 into symfony:6.3 Mar 29, 2023
@javiereguiluz
Copy link
Member

Thank you Bob for this contribution!

@bobvandevijver bobvandevijver deleted the cache-pool-clear-all branch March 29, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants