Add the new enum node type in 2.1 #1826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -100,6 +100,7 @@ node definition. Node type are available for: | |||
| * scalar | |||
| * boolean | |||
| * array | |||
| * enum (new in 2.1) | |||
There was a problem hiding this comment.
I prefer a .. versionadded: 2.1 block over this, you should place this block before this list.
There was a problem hiding this comment.
If I place it before the list, how it will target only the enum line? Do you have an example in the actual doc?
weaverryan
added a commit
that referenced
this pull request
Oct 31, 2012
Add the new enum node type in 2.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #1751, here is a second PR, in order to finalize the #1732
@weaverryan can you merge it please?