Skip to content

[Frontend] Update package.json example path #18291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2023
Merged

[Frontend] Update package.json example path #18291

merged 1 commit into from
May 9, 2023

Conversation

mttsch
Copy link
Contributor

@mttsch mttsch commented May 7, 2023

@javiereguiluz javiereguiluz requested a review from weaverryan May 9, 2023 11:06
weaverryan
weaverryan approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that's correct - we normalized everything into assets/. 👍

@javiereguiluz javiereguiluz added this to the 5.4 milestone May 9, 2023
@javiereguiluz javiereguiluz changed the base branch from 6.2 to 5.4 May 9, 2023 14:38
@javiereguiluz javiereguiluz requested a review from xabbuh as a code owner May 9, 2023 14:38
@javiereguiluz javiereguiluz force-pushed the bugfix/ux-js-resources branch from e9c4f39 to b7d5c25 Compare May 9, 2023 14:38
@javiereguiluz javiereguiluz merged commit fc6b1d9 into symfony:5.4 May 9, 2023
@javiereguiluz
Copy link
Member

Matthias, thanks for updating the docs ... and congrats on your first Symfony Docs contribution 🎉

Ryan, thanks for the review!

@mttsch mttsch deleted the bugfix/ux-js-resources branch May 9, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weaverryan weaverryan weaverryan approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
front-end Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@mttsch @javiereguiluz @weaverryan @carsonbot