[Mailer] Improve the warning about signing messages in a listener #18296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatTheCat
force-pushed
the
sign-templated-email
branch
from
425af45 to
e45f6e9
Compare
|
Mathieu, thanks for this. I agree it's better to display this warning as early as possible. We did some tweaks while merging, but the essence of your contribution remained. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes symfony/symfony#50254
Following the code samples to sign/encrypt messages won’t work using
TemplatedEmail, because these are rendered onMessageEvent. It seems more logical to warn about this in theSigning and Encrypting Messagessection rather thanMailer Events.(Failures unrelated.)