[UX] Centralizing docs around StimulusBundle #18381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the simplification. Thanks for that! But we tend to avoid super short documents ... and this one is now 54-line long. Maybe it's too short? Would it make sense to combine it with some other article? Moreover, there are many concepts floating around front-end: Stimulus, UX, AssetMapper, Webpack Encore, etc. So, having many small documents could be confusing to readers. Thanks. |
weaverryan
force-pushed
the
ux-docs-stimulus-bundle
branch
from
57a64b2 to
2d4a25f
Compare
weaverryan
commented
Jun 13, 2023
| @@ -480,7 +478,8 @@ Encore supports many more features! For a full list of what you can do, see | |||
| .. _`WebpackEncoreBundle Configuration`: https://github.com/symfony/webpack-encore-bundle#configuration | |||
| .. _`Stimulus`: https://stimulus.hotwired.dev/ | |||
| .. _`Stimulus Documentation`: https://stimulus.hotwired.dev/handbook/introduction | |||
| .. _`Symfony Stimulus Bridge`: https://github.com/symfony/stimulus-bridge | |||
| .. _StimulusBundle & the UX System: https://symfony.com/bundles/StimulusBundle/current/index.html | |||
| .. _all the Symfony UX packages: https://symfony.com/bundles/StimulusBundle/current/index.html#ux-packages | |||
There was a problem hiding this comment.
Whenever StimulusBundle docs build next, this should be there. It's from symfony/ux#930
|
Ready to go - I agree on removing the UX page entirely... I was also pondering that. It's done now - with a redirection to the StimulusBundle docs. |
javiereguiluz
approved these changes
Jun 14, 2023
|
Thank you Ryan. |
javiereguiluz
force-pushed
the
ux-docs-stimulus-bundle
branch
from
f953974 to
526faaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This goes with symfony/ux#930
Basically, now that StimulusBundle exists, it is the "heart" of UX: installing it activates Stimulus in your app + integration with the UX packages. And so, I've shortened this document and moved most of the instructions into StimulusBundle instead.
Let me know your thoughts.
Thanks!