Skip to content

Added cookbook entry on dynamic form generation based on services #1840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

khepin
Copy link
Contributor

@khepin khepin commented Oct 22, 2012

No description provided.

@stof
Copy link
Member

stof commented Oct 22, 2012

111 files changed ? Looks like you messed your commits

@wouterj
Copy link
Member

wouterj commented Oct 22, 2012

I have commented on the first commit, because the second commit makes things really bad...

You should create a new PR with only the first commit, maybe you should create a new branch and only add the article and create a PR based on that branch.

This isn't a 2.1 feature and it should be based on and merged into the 2.0 branch.

@khepin
Copy link
Contributor Author

khepin commented Oct 22, 2012

Yikes! Messed up my commits indeed! ... I'm coming back with a cleaner commit asap!

@khepin
Copy link
Contributor Author

khepin commented Oct 22, 2012

I made the changes suggested by @wouterj and opened a new clean pull request based on the 2.0 branch.

So I am closing this one.

@khepin khepin closed this Oct 22, 2012
@khepin
Copy link
Contributor Author

khepin commented Oct 22, 2012

New PR is #1842

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants