Remove all 6.x deprecations on 7.0 #18448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See my explanation in |
|
I changed my mind for the deprecations and would like to merge this PR. Can you please rebase and make the CI green? Feel free to ping me afterwards 😄 Thank you |
alexandre-daubois
force-pushed
the
remove-deprecations
branch
3 times, most recently
from
25e8343 to
9bfa841
Compare
|
@OskarStark rebase done 🙂 Should I make the same for #18449 or do you prefer to keep it on hold? |
|
Let's keep that one on hold 👍🏻 |
OskarStark
approved these changes
Aug 16, 2023
alexandre-daubois
force-pushed
the
remove-deprecations
branch
from
9bfa841 to
674037b
Compare
|
Thank you Alexandre. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.