Skip to content

Importmaps => import maps #18532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Conversation

ThomasLandauer
Copy link
Contributor

@ThomasLandauer ThomasLandauer commented Jul 7, 2023

Page: https://symfony.com/doc/current/frontend/asset_mapper.html

That's the official spelling, see https://html.spec.whatwg.org/multipage/webappapis.html#import-maps

Besides, this sounded weird:

Importmaps is a native browser feature.

That's the official spelling, see https://html.spec.whatwg.org/multipage/webappapis.html#import-maps

Besides, this sounded weird:
> Importmaps is a native browser feature.
@javiereguiluz
Copy link
Member

Good catch, thanks Thomas.

@javiereguiluz javiereguiluz merged commit 8ecadf2 into symfony:6.3 Jul 7, 2023
@ThomasLandauer ThomasLandauer deleted the patch-10 branch July 7, 2023 13:35
@ThomasLandauer
Copy link
Contributor Author

@javiereguiluz Sorry, but I'm not sure anymore about this! Take a look at https://symfony.com/doc/current/frontend/asset_mapper.html and search for "importmap":

  • If we change them all to "import map", it's inconsistent with the code importmap.
  • If we go with "importmap", it deviates from the official spelling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants